[Lldb-commits] [PATCH] Make --thread option optional (MI)

[Hafiz Abid Qadeer]

Some comments:

Please make one patch that is focussed on one problem. Unrelated changes should be in a separate patch. This way it is easy to review/commit. Also it is easy if it has to be reverted later. I think I can take care of this patch by committing related changes together. But please take care of it in future.

The changes to make the --thread optional looks valid to me. I think they can go in now.

The changes in test cases may need a bit more work though. The use of 0 as start and end address in -data-disassemble does not look good. Some stepping tests are timing out for me so need more investigation. Also I dont understand what the changes in a.c and b.c are supposed to achieve. Can you describe in a few lines.

Thanks,
Abid


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D7268

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/