[Lldb-commits] [PATCH] Get test/types tests passing on remote targets
Zachary Turner
zturner at google.com
Wed Jan 28 15:53:46 PST 2015
================
Comment at: test/types/AbstractBase.py:93-95
@@ -96,5 +92,5 @@
with open(self.golden_filename) as f:
go = f.read()
# This golden list contains a list of (variable, value) pairs extracted
# from the golden output.
----------------
For portability this should use the python tempfile module, and also it should not use hardcoded paths like /foo
================
Comment at: test/types/AbstractBase.py:177-180
@@ -184,6 +176,6 @@
# This golden list contains a list of (variable, value) pairs extracted
# from the golden output.
gl = []
# Scan the golden output line by line, looking for the pattern:
#
----------------
Same as above.
http://reviews.llvm.org/D7221
EMAIL PREFERENCES
http://reviews.llvm.org/settings/panel/emailpreferences/
More information about the lldb-commits
mailing list