[Lldb-commits] [PATCH] Launch lldb-gdbserver in same process group when launched remotely using lldb-platform.

[Robert Flack]

In http://reviews.llvm.org/D7211#114246, @ovyalov wrote:

> Do we need to call SetLaunchInSeparateProcessGroup(true) here https://github.com/llvm-mirror/lldb/blob/0d9ea6ba74541fe4a73df96122dc7a5913ac91e5/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp#L1918?


No, this is how the server is launched when run from lldb-platform, where we don't want it to run in a separate process group. Note the m_is_platform check here:
https://github.com/llvm-mirror/lldb/blob/0d9ea6ba74541fe4a73df96122dc7a5913ac91e5/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp#L1887

I could call SetLaunchInSeparateProcessGroup(false) to make that explicit.


REPOSITORY
  rL LLVM

http://reviews.llvm.org/D7211

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/