[Lldb-commits] [lldb] r227120 - Add an overload of SetValueFromCString() to ValueObjectSynthetic that is just a passthrough to the parent object

[Ed Maste]

On 26 January 2015 at 14:33, Enrico Granata <egranata at apple.com> wrote:
> Author: enrico
> Date: Mon Jan 26 13:33:52 2015
> New Revision: 227120
>
> URL: http://llvm.org/viewvc/llvm-project?rev=227120&view=rev
> Log:
> Add an overload of SetValueFromCString() to ValueObjectSynthetic that is just a passthrough to the parent object
>
> Without this overload, attempts to edit the value of a variable with synthetic children enabled would change the value inside the synthetic ValueObject, but not propagate the changes to the underlying storage, hence resulting in no write for any meaningful purpose
>
> Comes with a test case, and fixes rdar://19586311

The test fails on FreeBSD:

Traceback (most recent call last):
  File "dotest.py", line 1307, in <module>
    os.path.walk(testdir, visit, 'Test')
  File "/usr/local/lib/python2.7/posixpath.py", line 246, in walk
    walk(name, func, arg)
  File "/usr/local/lib/python2.7/posixpath.py", line 246, in walk
    walk(name, func, arg)
  File "/usr/local/lib/python2.7/posixpath.py", line 246, in walk
    walk(name, func, arg)
  File "/usr/local/lib/python2.7/posixpath.py", line 238, in walk
    func(arg, top, names)
  File "dotest.py", line 1191, in visit
    unittest2.defaultTestLoader.loadTestsFromName(filterspec, module))
  File "/tank/emaste/src/llvm/tools/lldb/test/unittest2/loader.py",
line 129, in loadTestsFromName
    return self.suiteClass([parent(obj.__name__)])
  File "/tank/emaste/src/llvm/tools/lldb/test/unittest2/case.py", line
224, in __init__
    (self.__class__, methodName))
ValueError: no such test method in <class
'lldbinline.TestSetValueFromCString'>: __test_with_dwarf