[Lldb-commits] [lldb] r227153 - Fix the test to disassemble as if at address zero, not at an invalid address. The default SBAddress constructor sets the offset to 0xffffffffffffffff and the section to NULL.

[Greg Clayton]

Author: gclayton
Date: Mon Jan 26 18:22:36 2015
New Revision: 227153

URL: http://llvm.org/viewvc/llvm-project?rev=227153&view=rev
Log:
Fix the test to disassemble as if at address zero, not at an invalid address. The default SBAddress constructor sets the offset to 0xffffffffffffffff and the section to NULL.

This was causing problems on clang 602 branches that use MemoryObjects to as the container for opcode bytes instead of a plain array of bytes. So we were asking for 3 bytes to be disassembled at address 0xffffffffffffffff which would cause an unsigned overflow and cause the MemoryObject to refuse to read anymore bytes.


Modified:
    lldb/trunk/test/python_api/disassemble-raw-data/TestDisassembleRawData.py

Modified: lldb/trunk/test/python_api/disassemble-raw-data/TestDisassembleRawData.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/python_api/disassemble-raw-data/TestDisassembleRawData.py?rev=227153&r1=227152&r2=227153&view=diff
==============================================================================
--- lldb/trunk/test/python_api/disassemble-raw-data/TestDisassembleRawData.py (original)
+++ lldb/trunk/test/python_api/disassemble-raw-data/TestDisassembleRawData.py Mon Jan 26 18:22:36 2015
@@ -26,7 +26,7 @@ class DisassembleRawDataTestCase(TestBas
 
         raw_bytes = bytearray([0x48, 0x89, 0xe5])
 
-        insts = target.GetInstructions(lldb.SBAddress(), raw_bytes)
+        insts = target.GetInstructions(lldb.SBAddress(0, target), raw_bytes)
 
         inst = insts.GetInstructionAtIndex(0)