[Lldb-commits] [PATCH] Clear should reset error to invalid instead of generic

Chaoren Lin chaorenl at google.com
Thu Jan 22 10:19:30 PST 2015


Here's more context. The default constructor uses eErrorTypeInvalid, so Clear() should also reset to eErrorTypeInvalid.


http://reviews.llvm.org/D7113

Files:
  source/Core/Error.cpp

Index: source/Core/Error.cpp
===================================================================
--- source/Core/Error.cpp
+++ source/Core/Error.cpp
@@ -146,7 +146,7 @@
 Error::Clear ()
 {
     m_code = 0;
-    m_type = eErrorTypeGeneric;
+    m_type = eErrorTypeInvalid;
     m_string.clear();
 }

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D7113.18623.patch
Type: text/x-patch
Size: 300 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150122/134cc942/attachment.bin>


More information about the lldb-commits mailing list