[Lldb-commits] [PATCH] Clear should reset error to invalid instead of generic

[Chaoren Lin]

It doesn't make much of a difference really, but the default type of an
error is invalid. It seems weird that clear doesn't produce the same thing
as the default constructor.
On Jan 21, 2015 6:43 PM, "Siva Chandra" <sivachandra at google.com> wrote:

> ================
> Comment at: source/Core/Error.cpp:149
> @@ -148,3 +148,3 @@
>      m_code = 0;
> -    m_type = eErrorTypeGeneric;
> +    m_type = eErrorTypeInvalid;
>      m_string.clear();
> ----------------
> Drive by comment:
> While I do not know if this OK or not, you should explain why this change
> is required in your commit message.
>
> http://reviews.llvm.org/D7113
>
> EMAIL PREFERENCES
>   http://reviews.llvm.org/settings/panel/emailpreferences/
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150121/234e937a/attachment.html>