[Lldb-commits] [PATCH] Fix darwin-debug build in cmake (OS X)

[Zachary Turner]

LGTM


================
Comment at: tools/darwin-debug/CMakeLists.txt:1
@@ +1,2 @@
+add_lldb_executable(lldb-launcher
+  darwin-debug.cpp
----------------
ki.stfu wrote:
> zturner wrote:
> > Should the executable be called darwin-debug instead of lldb-launcher?
> I don't mind. I took it from lldb.xcodeproj/project.pbxproj:
> ```
>         26579F67126A25920007C5CB /* darwin-debug */ = {
>             isa = PBXNativeTarget;
>             buildConfigurationList = 26579F6D126A25BF0007C5CB /* Build configuration list for PBXNativeTarget "darwin-debug" */;
>             buildPhases = (
>                 26579F65126A25920007C5CB /* Sources */,
>                 26579F66126A25920007C5CB /* Frameworks */,
>             );
>             buildRules = (
>             );
>             dependencies = (
>             );
>             name = "darwin-debug";
>             productName = "lldb-launcher";
>             productReference = 26579F68126A25920007C5CB /* darwin-debug */;
>             productType = "com.apple.product-type.tool";
>         };
> ```
Ahh, probably best to match the xcode project then.

http://reviews.llvm.org/D7102

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/