[Lldb-commits] [lldb] r226608 - Remove unused function:

Greg Clayton gclayton at apple.com
Tue Jan 20 13:05:21 PST 2015


Author: gclayton
Date: Tue Jan 20 15:05:21 2015
New Revision: 226608

URL: http://llvm.org/viewvc/llvm-project?rev=226608&view=rev
Log:
Remove unused function:

lldb::pid_t
Host::LaunchApplication (const FileSpec &app_file_spec);

This had use of a function FSPathMakeRef(const UInt8*, FSRef *, ...) that was deprecated in 10.8. 

Removing this fucntion since it wasn't used and was causing warnings.


Modified:
    lldb/trunk/include/lldb/Host/Host.h
    lldb/trunk/source/Host/common/Host.cpp
    lldb/trunk/source/Host/macosx/Host.mm

Modified: lldb/trunk/include/lldb/Host/Host.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/Host/Host.h?rev=226608&r1=226607&r2=226608&view=diff
==============================================================================
--- lldb/trunk/include/lldb/Host/Host.h (original)
+++ lldb/trunk/include/lldb/Host/Host.h Tue Jan 20 15:05:21 2015
@@ -246,9 +246,6 @@ public:
     static const lldb_private::UnixSignalsSP&
     GetUnixSignals ();
 
-    static lldb::pid_t
-    LaunchApplication (const FileSpec &app_file_spec);
-
     static Error
     LaunchProcess (ProcessLaunchInfo &launch_info);
 

Modified: lldb/trunk/source/Host/common/Host.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/common/Host.cpp?rev=226608&r1=226607&r2=226608&view=diff
==============================================================================
--- lldb/trunk/source/Host/common/Host.cpp (original)
+++ lldb/trunk/source/Host/common/Host.cpp Tue Jan 20 15:05:21 2015
@@ -1052,12 +1052,6 @@ Host::SetCrashDescription (const char *d
 {
 }
 
-lldb::pid_t
-Host::LaunchApplication (const FileSpec &app_file_spec)
-{
-    return LLDB_INVALID_PROCESS_ID;
-}
-
 #endif
 
 #if !defined (__linux__) && !defined (__FreeBSD__) && !defined (__NetBSD__)

Modified: lldb/trunk/source/Host/macosx/Host.mm
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/macosx/Host.mm?rev=226608&r1=226607&r2=226608&view=diff
==============================================================================
--- lldb/trunk/source/Host/macosx/Host.mm (original)
+++ lldb/trunk/source/Host/macosx/Host.mm Tue Jan 20 15:05:21 2015
@@ -128,49 +128,6 @@ Host::ResolveExecutableInBundle (FileSpe
   return false;
 }
 
-lldb::pid_t
-Host::LaunchApplication (const FileSpec &app_file_spec)
-{
-#if defined (__arm__) || defined(__arm64__) || defined(__aarch64__)
-    return LLDB_INVALID_PROCESS_ID;
-#else
-    char app_path[PATH_MAX];
-    app_file_spec.GetPath(app_path, sizeof(app_path));
-
-    LSApplicationParameters app_params;
-    ::memset (&app_params, 0, sizeof (app_params));
-    app_params.flags = kLSLaunchDefaults | 
-                       kLSLaunchDontAddToRecents | 
-                       kLSLaunchNewInstance;
-    
-    
-    FSRef app_fsref;
-    CFCString app_cfstr (app_path, kCFStringEncodingUTF8);
-    
-    OSStatus error = ::FSPathMakeRef ((const UInt8 *)app_path, &app_fsref, NULL);
-    
-    // If we found the app, then store away the name so we don't have to re-look it up.
-    if (error != noErr)
-        return LLDB_INVALID_PROCESS_ID;
-    
-    app_params.application = &app_fsref;
-
-    ProcessSerialNumber psn;
-
-    error = ::LSOpenApplication (&app_params, &psn);
-
-    if (error != noErr)
-        return LLDB_INVALID_PROCESS_ID;
-
-    ::pid_t pid = LLDB_INVALID_PROCESS_ID;
-    error = ::GetProcessPID(&psn, &pid);
-    if (error != noErr)
-        return LLDB_INVALID_PROCESS_ID;
-    return pid;
-#endif
-}
-
-
 static void *
 AcceptPIDFromInferior (void *arg)
 {





More information about the lldb-commits mailing list