[Lldb-commits] [PATCH] Add -exec-arguments command
Hafiz Abid Qadeer
abidh.haq at gmail.com
Mon Jan 19 04:44:17 PST 2015
Looks ok to me. 2 comments though.
1. Why are changes in SBTarget when you are not using them.
2. I think the test cases for arguments are currently skipped (@unittest2.skip("requires 'quotes' and 'CLI support' patches")). Currently, we can test for argc. So I think at least that portion should be enabled as that gives us some coverage. I will have to see why argv is not being evaluated.
If nobody else comments then I can commit this patch in a day or 2 with modification suggested above.
More information about the lldb-commits