[Lldb-commits] [lldb] r226362 - Added Connection::GetURI()

[Zachary Turner]

Fwiw that's generally what people do on the llvm side when they're unable
to compile on a particular platform but one of the changes broke the build.
If the only remaining errors are ones that are not obvious then someone who
works on that platform will usually jump in and help. Keeping the tree
green is priority 1, so if nobody can help right away it's best to revert
until it can be figured out.
On Fri, Jan 16, 2015 at 9:45 PM Vince Harron <vharron at google.com> wrote:

> I could guess that one.  But I don't want to get into a compile-via-submit
> loop.
>
> On Fri, Jan 16, 2015 at 9:43 PM, Zachary Turner <zturner at google.com>
> wrote:
>
>> Most of the time you can fix by just looking at the error message. In
>> this case it looks like you need to add a #include <string>
>> On Fri, Jan 16, 2015 at 9:40 PM Vince Harron <vharron at google.com> wrote:
>>
>>> I'm hitting a problem building Windows using the provided instructions.
>>> Zach will be looking into it early next week.
>>>
>>>
>>> On Fri, Jan 16, 2015 at 8:13 PM, Chandler Carruth <chandlerc at google.com>
>>> wrote:
>>>
>>>>
>>>> On Fri, Jan 16, 2015 at 6:20 PM, Vince Harron <vharron at google.com>
>>>> wrote:
>>>>
>>>>> Added Connection::GetURI()
>>>>>
>>>>> This function returns a URI of the resource that the connection is
>>>>> connected to. This is especially important for connections established by
>>>>> accepting a connection from a remote host.
>>>>>
>>>>> Also added implementations for ConnectionMachPort,
>>>>> ConnectionSharedMemory,
>>>>> Also fixed up some documentation in Connection::Write
>>>>> Renamed ConnectionFileDescriptorPosix::SocketListen to
>>>>> ConnectionFileDescriptorPosix::SocketListenAndAccept
>>>>> Fixed a log message in Socket.cpp
>>>>>
>>>>> Differential Review: http://reviews.llvm.org/D7026
>>>>>
>>>>
>>>> This broke the windows build:
>>>> http://lab.llvm.org:8011/builders/lldb-x86-win7-msvc/builds/58
>>>>
>>>
>>>
>>>
>>> --
>>>
>>> Vince Harron | Technical Lead Manager | vharron at google.com |
>>> 858-442-0868
>>>  _______________________________________________
>>> lldb-commits mailing list
>>> lldb-commits at cs.uiuc.edu
>>> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits
>>>
>>
>
>
> --
>
> Vince Harron | Technical Lead Manager | vharron at google.com | 858-442-0868
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150117/c1281870/attachment.html>