[Lldb-commits] [PATCH] Extend PipePosix with support for named pipes/timeout-based IO and integrate it with GDBRemoteCommunication / lldb-gdbserver.

Zachary Turner zturner at google.com
Tue Jan 13 12:53:19 PST 2015


================
Comment at: source/Host/posix/PipePosix.cpp:186
@@ -108,3 +185,3 @@
 Error
-PipePosix::OpenAsReader(llvm::StringRef name, bool child_process_inherit)
+PipePosix::OpenAsReaderWithTimeout(llvm::StringRef name, bool child_process_inherit, const std::chrono::microseconds &timeout)
 {
----------------
Why did we change this from OpenAsReader to OpenAsReaderWithTimeout?  The timeout is never used, for one thing, so it's buggy, and it's less flexible, since you can't specify the timeout on individual reads.

http://reviews.llvm.org/D6954

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list