[Lldb-commits] [PATCH] [InlineTest] getRerunArgs returns an empty string if the test was skipped.

Siva Chandra sivachandra at google.com
Thu Jan 8 17:23:49 PST 2015

Hi clayborg, vharron,

The main issue that this patch is trying to address is that the current
implementation of getRerunArgs of InlineTest relies on the attribute
'using_dsym' which could be absent if the test was skipped altogether.
[That is, if both dsym and dwarf tests were skipped.]

While at it, the use of deprecated Python module 'new' is eliminated.



Index: test/lldbinline.py
--- test/lldbinline.py
+++ test/lldbinline.py
@@ -2,7 +2,6 @@
 from lldbtest import *
 import lldbutil
 import os
-import new
 import unittest2
 import sys
@@ -72,7 +71,10 @@
     def getRerunArgs(self):
         # The -N option says to NOT run a if it matches the option argument, so
         # if we are using dSYM we say to NOT run dwarf (-N dwarf) and vice versa.
-        if self.using_dsym:
+        if self.using_dsym is None:
+            # The test was skipped altogether.
+            return ""
+        elif self.using_dsym:
             return "-N dwarf %s" % (self.mydir)
             return "-N dsym %s" % (self.mydir)
@@ -179,7 +181,7 @@
     test_name, _ = os.path.splitext(file_basename)
     # Build the test case 
-    test = new.classobj(test_name, (InlineTest,), {})
+    test = type(test_name, (InlineTest,), {'using_dsym': None})
     test.name = test_name
     test.test_with_dsym = ApplyDecoratorsToFunction(test._InlineTest__test_with_dsym, decorators)

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6888.17919.patch
Type: text/x-patch
Size: 1094 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150109/fd278903/attachment.bin>

More information about the lldb-commits mailing list