[Lldb-commits] [PATCH] Modify dotest.py to be able to run without an lldb build.

Saleem Abdulrasool compnerd at compnerd.org
Wed Jan 7 18:02:23 PST 2015

Comment at: test/dotest.py:950
@@ -948,4 +949,3 @@
-            print lldbExecutablePath + " is not an executable"
-            sys.exit(-1)
+            print lldbExecutablePath + " is not an executable, lldb tests will fail."
sas wrote:
> compnerd wrote:
> > Whats the point of running tests if they are going to fail since you don't have the necessary dependencies?
> Because you can run other tests (not lldb) with this tool. Only the lldb tests will fail if you choose to run them.
Not sure I understand.  What are these other tests?

Comment at: test/tools/lldb-gdbserver/lldbgdbserverutils.py:66
@@ -62,1 +65,3 @@
+        else:
+            return _get_debug_monitor_from_lldb(lldb_exe, "lldb-gdbserver")
sas wrote:
> compnerd wrote:
> > This might be simpler to read:
> > 
> >     for var in ("LLDB_DEBUGSERVER_PATH", "LLDB_EXEC"):
> >       if os.environ.get(var, None):
> >         return _get_debug_monitor_from_lldb(os.environ[var], "lldb-gdbserver")
> >     return None
> Not really, because when the user specifies LLDB_DEBUGSERVER_PATH, we don't want to go through _gert_debug_monitor_from_lldb again, we just want to use the path directly.
Why do we want the different behavior for the two?



More information about the lldb-commits mailing list