[Lldb-commits] [lldb] r225418 - Fix a problem where a ValueObject could fail to update itself, but since it was previously valid, we'd have an old checksum to compare aginst no new checksum (because failure to update), and assert() and die. Fix the problem by only caring about this assertion logic if updates succeed

[Enrico Granata]

If you end up with a reproducible case of the assertion firing, totally let me know - bugzilla or just an email
Hopefully it’s not so Windows-specific that I can’t get it to happen on Mac

> On Jan 7, 2015, at 4:33 PM, Zachary Turner <zturner at google.com> wrote:
> 
> Cool, i think this assertion was actually firing on windows, making it very annoying to run the test suite. I hope this fixes that
> On Wed, Jan 7, 2015 at 4:30 PM Enrico Granata <egranata at apple.com <mailto:egranata at apple.com>> wrote:
> Author: enrico
> Date: Wed Jan  7 18:29:12 2015
> New Revision: 225418
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=225418&view=rev <http://llvm.org/viewvc/llvm-project?rev=225418&view=rev>
> Log:
> Fix a problem where a ValueObject could fail to update itself, but since it was previously valid, we'd have an old checksum to compare aginst no new checksum (because failure to update), and assert() and die. Fix the problem by only caring about this assertion logic if updates succeed
> 
> Modified:
>     lldb/trunk/source/Core/ValueObject.cpp
> 
> Modified: lldb/trunk/source/Core/ValueObject.cpp
> URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/ValueObject.cpp?rev=225418&r1=225417&r2=225418&view=diff <http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/ValueObject.cpp?rev=225418&r1=225417&r2=225418&view=diff>
> ==============================================================================
> --- lldb/trunk/source/Core/ValueObject.cpp (original)
> +++ lldb/trunk/source/Core/ValueObject.cpp Wed Jan  7 18:29:12 2015
> @@ -250,7 +250,7 @@ ValueObject::UpdateValueIfNeeded (bool u
>                  m_value_checksum.clear();
>              }
> 
> -            assert (old_checksum.empty() == !need_compare_checksums);
> +            assert (success && (old_checksum.empty() == !need_compare_checksums));
> 
>              if (first_update)
>                  SetValueDidChange (false);
> 
> 
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu <mailto:lldb-commits at cs.uiuc.edu>
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits <http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits>

Thanks,
- Enrico
📩 egranata@.com ☎️ 27683




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20150107/86548870/attachment.html>