[Lldb-commits] [lldb] r225418 - Fix a problem where a ValueObject could fail to update itself, but since it was previously valid, we'd have an old checksum to compare aginst no new checksum (because failure to update), and assert() and die. Fix the problem by only caring about this assertion logic if updates succeed

[Enrico Granata]

Author: enrico
Date: Wed Jan  7 18:29:12 2015
New Revision: 225418

URL: http://llvm.org/viewvc/llvm-project?rev=225418&view=rev
Log:
Fix a problem where a ValueObject could fail to update itself, but since it was previously valid, we'd have an old checksum to compare aginst no new checksum (because failure to update), and assert() and die. Fix the problem by only caring about this assertion logic if updates succeed

Modified:
    lldb/trunk/source/Core/ValueObject.cpp

Modified: lldb/trunk/source/Core/ValueObject.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Core/ValueObject.cpp?rev=225418&r1=225417&r2=225418&view=diff
==============================================================================
--- lldb/trunk/source/Core/ValueObject.cpp (original)
+++ lldb/trunk/source/Core/ValueObject.cpp Wed Jan  7 18:29:12 2015
@@ -250,7 +250,7 @@ ValueObject::UpdateValueIfNeeded (bool u
                 m_value_checksum.clear();
             }
             
-            assert (old_checksum.empty() == !need_compare_checksums);
+            assert (success && (old_checksum.empty() == !need_compare_checksums));
             
             if (first_update)
                 SetValueDidChange (false);