[Lldb-commits] [lldb] r225195 - Fix about 20 tests on Windows.

Zachary Turner zturner at google.com
Mon Jan 5 11:37:03 PST 2015


Author: zturner
Date: Mon Jan  5 13:37:03 2015
New Revision: 225195

URL: http://llvm.org/viewvc/llvm-project?rev=225195&view=rev
Log:
Fix about 20 tests on Windows.

Passing the argument string from dosep to dotest was failing on
Windows due to the fact that Windows uses \ for its path separator.
As a result, shlex.split() was treating it as an escape character.
This fixes the issue by telling shlex.split() to not use posix mode
when running on Windows.

Modified:
    lldb/trunk/test/dosep.py

Modified: lldb/trunk/test/dosep.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/dosep.py?rev=225195&r1=225194&r2=225195&view=diff
==============================================================================
--- lldb/trunk/test/dosep.py (original)
+++ lldb/trunk/test/dosep.py Mon Jan  5 13:37:03 2015
@@ -64,8 +64,11 @@ def process_dir(root, files, test_root,
         if os.path.islink(path):
             continue
 
-        command = ([sys.executable, "%s/dotest.py" % test_root] +
-                   (shlex.split(dotest_options) if dotest_options else []) +
+        script_file = os.path.join(test_root, "dotest.py")
+        is_posix = (os.name == "posix")
+        split_args = shlex.split(dotest_options, posix=is_posix) if dotest_options else []
+        command = ([sys.executable, script_file] +
+                   split_args +
                    ["-p", name, root])
 
         timeout_name = os.path.basename(os.path.splitext(name)[0]).upper()





More information about the lldb-commits mailing list