[Lldb-commits] [PATCH] lldb-mi: print the prompt after commands

Ilia K ki.stfu at gmail.com
Wed Dec 31 02:35:30 PST 2014


Hello,

Now I doubt about these changes because I had mixed (gdb) hard coded prompt
and prompt of MI (that can be changed or disabled). I'll prepare another
patch which will fix this.

Thanks,
Ilia

On Mon, Dec 22, 2014 at 2:43 PM, Ilia K <ki.stfu at gmail.com> wrote:

> Hello,
>
> My previous letter is left without answer. I'm sending it again (see
> below).
>
> Thanks,
> Ilia
>
> ---------- Forwarded message ----------
> From: Ilia K <ki.stfu at gmail.com>
> Date: Wed, Dec 17, 2014 at 6:04 PM
> Subject: Fwd: [Lldb-commits] [PATCH] lldb-mi: print the prompt after
> commands
> To: "lldb-commits at cs.uiuc.edu" <lldb-commits at cs.uiuc.edu>
>
>
> Hello,
>
> It seems my previous message wasn't included in the mailing list. See it
> below, please.
>
> Thanks,
> Ilia
>
> ---------- Forwarded message ----------
> From: Ilia K <ki.stfu at gmail.com>
> Date: Tue, Dec 16, 2014 at 3:43 PM
> Subject: [Lldb-commits] [PATCH] lldb-mi: print the prompt after commands
> To: "Abid, Hafiz" <Hafiz_Abid at mentor.com>, "lldb-commits at cs.uiuc.edu" <
> lldb-commits at cs.uiuc.edu>
>
> Hello,
>
> This patch contains the fix of prompt's printing after commands in MI mode.
>
> Previously the prompt was printed in MICmnStreamStdin::MonitorStdin before
> ::fgets() was called what was wrong because lldb-mi has separate thread to
> read user's input. Therefore prompt was printed after each user's input
> even if command hadn't been executed. In this patch prompt is printed after
> the command is executed.
> Also, early the prompt was declared in different places. I have refactored
> this code and have moved it to CMICmnStreamStdout::WritePrompt function.
> And finally I added checks for my improvements in TestMiBreakpoint test.
>
> Thanks,
> Ilia
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20141231/6a51d623/attachment.html>


More information about the lldb-commits mailing list