[Lldb-commits] [PATCH] Modify dotest.py to be able to run without an lldb build.

[Stephane Sezer]

Thanks for the review Saleem. See comments inline.


================
Comment at: test/dotest.py:950
@@ -948,4 +949,3 @@
         else:
-            print lldbExecutablePath + " is not an executable"
-            sys.exit(-1)
+            print lldbExecutablePath + " is not an executable, lldb tests will fail."
     else:
----------------
compnerd wrote:
> Whats the point of running tests if they are going to fail since you don't have the necessary dependencies?
Because you can run other tests (not lldb) with this tool. Only the lldb tests will fail if you choose to run them.

================
Comment at: test/tools/lldb-gdbserver/lldbgdbserverutils.py:60
@@ +59,3 @@
+    if "LLDB_DEBUGSERVER_PATH" in os.environ:
+        return os.environ["LLDB_DEBUGSERVER_PATH"]
+    elif "LLDB_EXEC" in os.environ:
----------------
compnerd wrote:
> Might be nice to do a check similar to the one below to ensure that the DebugServer is present.
The existence of the debug server is checked elsewhere in the test suite (in lldbgdbserverutils.py).

================
Comment at: test/tools/lldb-gdbserver/lldbgdbserverutils.py:66
@@ -62,1 +65,3 @@
+        else:
+            return _get_debug_monitor_from_lldb(lldb_exe, "lldb-gdbserver")
     else:
----------------
compnerd wrote:
> This might be simpler to read:
> 
>     for var in ("LLDB_DEBUGSERVER_PATH", "LLDB_EXEC"):
>       if os.environ.get(var, None):
>         return _get_debug_monitor_from_lldb(os.environ[var], "lldb-gdbserver")
>     return None
Not really, because when the user specifies LLDB_DEBUGSERVER_PATH, we don't want to go through _gert_debug_monitor_from_lldb again, we just want to use the path directly.

================
Comment at: test/tools/lldb-gdbserver/lldbgdbserverutils.py:86
@@ -75,3 +85,3 @@
     else:
-        return _get_debug_monitor_from_lldb(lldb_exe, "debugserver")
+        return None
 
----------------
compnerd wrote:
> Similar to above.  This might be simpler to read:
> 
>     for var in ("LLDB_DEBUGSERVER_PATH", "LLDB_EXEC"):
>       if os.environ.get(var, None):
>         return _get_debug_monitor_from_lldb(os.environ[var], "debugserver")
>     return None
Ditto.

http://reviews.llvm.org/D6554

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/