[Lldb-commits] [PATCH] No need to call SetErrorToErrno when pipe2 succeeds.

[Oleksiy Vyalov]

Hi zturner,

In http://reviews.llvm.org/D6686 I mistakenly advised to call SetErrorToErrno when pipe2 succeeds - this causes TestCommandSource to fail on Linux.
Removing SetErrorToErrno call from successful execution branch.

http://reviews.llvm.org/D6743

Files:
  source/Host/posix/PipePosix.cpp

Index: source/Host/posix/PipePosix.cpp
===================================================================
--- source/Host/posix/PipePosix.cpp
+++ source/Host/posix/PipePosix.cpp
@@ -67,10 +67,7 @@
 
 #if PIPE2_SUPPORTED
     if (::pipe2(m_fds, (child_processes_inherit) ? 0 : O_CLOEXEC) == 0)
-    {
-        error.SetErrorToErrno();
         return error;
-    }
 #else
     if (::pipe(m_fds) == 0)
     {

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6743.17523.patch
Type: text/x-patch
Size: 408 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20141219/3e0b948b/attachment.bin>