[Lldb-commits] [lldb] r224644 - [TestEvents] Replace expectedFailureLinux with skipIfLinux

Siva Chandra sivachandra at google.com
Fri Dec 19 14:41:43 PST 2014


Author: sivachandra
Date: Fri Dec 19 16:41:43 2014
New Revision: 224644

URL: http://llvm.org/viewvc/llvm-project?rev=224644&view=rev
Log:
[TestEvents] Replace expectedFailureLinux with skipIfLinux

Summary:
If we do not mark them as skip, they are still executed, which in
turn is leading to an assertion failure. The change also adds
skipIfLinux to a testlet which was not previously marked with
skipIfLinux. This is because running even that test let leads to an
assertion failure.

Test Plan: dotest.py -C clang -p TestEvents.py

Reviewers: vharron

Reviewed By: vharron

Subscribers: lldb-commits

Differential Revision: http://reviews.llvm.org/D6715

Modified:
    lldb/trunk/test/python_api/event/TestEvents.py

Modified: lldb/trunk/test/python_api/event/TestEvents.py
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/test/python_api/event/TestEvents.py?rev=224644&r1=224643&r2=224644&view=diff
==============================================================================
--- lldb/trunk/test/python_api/event/TestEvents.py (original)
+++ lldb/trunk/test/python_api/event/TestEvents.py Fri Dec 19 16:41:43 2014
@@ -20,6 +20,9 @@ class EventAPITestCase(TestBase):
         self.buildDsym()
         self.do_listen_for_and_print_event()
 
+    @unittest2.skipUnless((sys.platform.startswith("darwin") or
+                           sys.platform.startswith("freebsd")),
+                          "requires Darwin or FreeBSD")
     @python_api_test
     @dwarf_test
     def test_listen_for_and_print_event_with_dwarf(self):
@@ -35,7 +38,7 @@ class EventAPITestCase(TestBase):
         self.buildDsym()
         self.do_wait_for_event()
 
-    @expectedFailureLinux # non-core functionality, need to reenable and fix later (DES 2014.11.07)
+    @skipIfLinux # non-core functionality, need to reenable and fix later (DES 2014.11.07)
     @python_api_test
     @dwarf_test
     def test_wait_for_event_with_dwarf(self):
@@ -52,7 +55,7 @@ class EventAPITestCase(TestBase):
         self.do_add_listener_to_broadcaster()
 
     @skipIfFreeBSD # llvm.org/pr21325
-    @expectedFailureLinux # non-core functionality, need to reenable and fix later (DES 2014.11.07)
+    @skipIfLinux # non-core functionality, need to reenable and fix later (DES 2014.11.07)
     @python_api_test
     @dwarf_test
     def test_add_listener_to_broadcaster_with_dwarf(self):





More information about the lldb-commits mailing list