[Lldb-commits] [PATCH] Don't generate lldb inline test Makefiles if Makefile already exists.

[Sean Callanan]

I think it’d be nice not to delete the Makefile… it can be useful for reproducing tests if they fail, removing one reason for manually checking in Makefiles.

I think, though, that CleanMakefile() should stay in but have an empty implementation, so that someone who doesn’t want the Makefiles sticking around can set an environment variable to delete them (You don’t have to actually implement that part, I can do it later, but I’d rather have CleanMakefile() around so I know where to do it.)

Sean

> On Dec 15, 2014, at 11:33 AM, Greg Clayton <clayborg at gmail.com> wrote:
> 
> Shouldn't the fact that the make file exists be stored in a class variable and then the class will still call CleanMakefile() if the make file didn't exist?
> 
> 
> http://reviews.llvm.org/D6664
> 
> EMAIL PREFERENCES
>  http://reviews.llvm.org/settings/panel/emailpreferences/
> 
> 
> 
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits