[Lldb-commits] [PATCH] Fix compilation faliures for x64 visual studio 2013 build

[Zachary Turner]

Looks good after addressing these comments.


================
Comment at: source/Plugins/Process/Windows/CMakeLists.txt:11
@@ -5,3 +10,3 @@
 
-add_lldb_library(lldbPluginProcessWindows
+add_process_windows_subdirectory(lldbPluginProcessWindows
   DebuggerThread.cpp
----------------
Change "lldbPluginProcessWindows" to "common".  This controls how it will show up in Solution Explorer but otherwise doesn't mean anything, so it should be descriptive of the category.

================
Comment at: source/Plugins/Process/Windows/CMakeLists.txt:20
@@ +19,3 @@
+if (CMAKE_SIZEOF_VOID_P EQUAL 4)
+  add_process_windows_subdirectory(lldbPluginProcessWindows
+  x86/RegisterContextWindows_x86.cpp
----------------
Change "lldbPluginProcessWindows" to "x86".

================
Comment at: source/Plugins/Process/Windows/TargetThreadWindows.cpp:20
@@ -20,1 +19,3 @@
 
+#if !defined (_M_IA64) && !defined(_M_X64)
+#include "x86/RegisterContextWindows_x86.h"
----------------
I don't think we will ever build for itanium, and a better check for 64-bitness is to use _WIN64.  So to be consistent with other places in the Windows codepath where we will need to check for 64-bitness, I would change this to

#if !defined(_WIN64)

================
Comment at: source/Plugins/Process/Windows/TargetThreadWindows.cpp:78
@@ -74,1 +77,3 @@
             case llvm::Triple::x86:
+#if defined (_M_IA64) || defined(_M_X64)
+                // FIXME: Support x64 by creating a RegisterContextWindows_x86_64
----------------
Same here, change to

#if defined(_WIN64)

http://reviews.llvm.org/D6704

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/