[Lldb-commits] [PATCH] Fix compilation faliures for x64 visual studio 2013 build

Zachary Turner zturner at google.com
Thu Dec 18 10:05:17 PST 2014


================
Comment at: source/Plugins/Process/Windows/TargetThreadWindows.cpp:79-82
@@ -75,2 +78,6 @@
+#if defined (_M_IA64) || defined(_M_X64)
+                // FIXME: Support x64 by creating a RegisterContextWindows_x86_64
+#else
                 m_reg_context_sp.reset(new RegisterContextWindows_x86(*this, idx));
+#endif
                 break;
----------------
Also, just as a heads up, I made one more change to the comment here.  if the triple is x86 and the host architecture is x64, that's a Wow64 process, not an x86_64 process.  That would occur if both the triple and the host architecture were x64.  So I added an empty case to the switch to handle llvm::Triple::x64 and moved your comment there, and changed this comment to refer to a RegisterContextWindows_Wow64.

http://reviews.llvm.org/D6704

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/






More information about the lldb-commits mailing list