[Lldb-commits] [PATCH] [TestEvents] Replace expectedFailureLinux with skipIfLinux

[Siva Chandra]

Hi vharron,

If we do not mark them as skip, they are still executed, which in
turn is leading to an assertion failure. The change also adds
skipIfLinux to a testlet which was not previously marked with
skipIfLinux. This is because running even that test let leads to an
assertion failure.

http://reviews.llvm.org/D6715

Files:
  test/python_api/event/TestEvents.py

Index: test/python_api/event/TestEvents.py
===================================================================
--- test/python_api/event/TestEvents.py
+++ test/python_api/event/TestEvents.py
@@ -20,6 +20,9 @@
         self.buildDsym()
         self.do_listen_for_and_print_event()
 
+    @unittest2.skipUnless((sys.platform.startswith("darwin") or
+                           sys.platform.startswith("freebsd")),
+                          "requires Darwin or FreeBSD")
     @python_api_test
     @dwarf_test
     def test_listen_for_and_print_event_with_dwarf(self):
@@ -35,7 +38,7 @@
         self.buildDsym()
         self.do_wait_for_event()
 
-    @expectedFailureLinux # non-core functionality, need to reenable and fix later (DES 2014.11.07)
+    @skipIfLinux # non-core functionality, need to reenable and fix later (DES 2014.11.07)
     @python_api_test
     @dwarf_test
     def test_wait_for_event_with_dwarf(self):
@@ -52,7 +55,7 @@
         self.do_add_listener_to_broadcaster()
 
     @skipIfFreeBSD # llvm.org/pr21325
-    @expectedFailureLinux # non-core functionality, need to reenable and fix later (DES 2014.11.07)
+    @skipIfLinux # non-core functionality, need to reenable and fix later (DES 2014.11.07)
     @python_api_test
     @dwarf_test
     def test_add_listener_to_broadcaster_with_dwarf(self):

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6715.17419.patch
Type: text/x-patch
Size: 1325 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20141218/65510ab8/attachment.bin>