[Lldb-commits] [PATCH] Fix compilation faliures for x64 visual studio 2013 build

[Zachary Turner]

I don't think this is the right fix.  For x64 we should implement an entirely different RegisterContext class in a file called RegisterContext_x86_64.  At some point we're going to want support debugging x86 targets with an x64 build of LLDB, but that has its own set of issues (notably that we will need to use Wow64GetThreadContext and a PWOW64_CONTEXT structure).  So that will probably also require its own RegisterContext implementation.  So the correct fix for this is to simply not compile this file on x64.  You can do that at the CMake level by editing lldb\source\Plugins\Process\Windows\CMakeLists.txt and conditionally adding RegisterContext_x86.cpp only for builds where CMAKE_SIZEOF_VOID_P EQUAL 4.

Then, in ProcessWindows.cpp you'll need to wrap any lines that #include "RegisterContext_x86.h" or allocate a RegisterContext_x86 object in a similar #ifdef.


http://reviews.llvm.org/D6704

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/