[Lldb-commits] [PATCH] Documentation for test timeout

[Zachary Turner]

That could still be solved with command line argument. For example:

--default-timeout=5m --test-timeout={'TestConcurrentEvents': '2m'}

Where the second one is a dictionary that can be directly parsed by python.
This also has the advantage of being easy to set in CMake, so that ninja
check-lldb will use reasonable timeouts.

I have to wonder though, is the ability to override test timeout worth the
added complexity (regardless of whether it uses environment variable or
command line)? How frequently will this be used? If a test is special
enough to want to override its timeout, it seems like maybe that should be
a property of the test, and not the person running the test. Imagine the
setup required to do this. It really complicates things over the current
state of "just run dotest.py" to ave to set all these environment variables
before running the script.

So i vote for one global timeout, and if it has to be overridable then an
attribute on the test class/method like @maxTimeout('2m') or
@minTimeout('10m') which would combine with the default.

Thoughts?


http://reviews.llvm.org/D6669

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/