[Lldb-commits] [PATCH] Allow some test suite options for dealing with crashing on Windows

[Scott Graham]

Otherwise, lgtm.


================
Comment at: source/lldb.cpp:149
@@ +148,3 @@
+            // suite, so that a crash in LLDB does not prevent completion of the test suite.
+            ::SetErrorMode(SEM_FAILCRITICALERRORS | SEM_NOGPFAULTERRORBOX);
+
----------------
Normally, preserve existing flags (they're returned). Chrome does something this:

  UINT new_flags = SEM_FAILCRITICALERRORS |
                   SEM_NOGPFAULTERRORBOX |
                   SEM_NOOPENFILEERRORBOX;
  UINT existing_flags = SetErrorMode(new_flags);
  SetErrorMode(existing_flags | new_flags);

================
Comment at: source/lldb.cpp:153
@@ +152,3 @@
+            // user interaction when LLDB asserts.
+            _CrtSetReportHook(AvoidMessageBoxHook);
+        }
----------------
I don't know if you link with /MT or /MD, but this will only work in this binary if /MT.

http://reviews.llvm.org/D6628

EMAIL PREFERENCES
  http://reviews.llvm.org/settings/panel/emailpreferences/