[Lldb-commits] [lldb] r223501 - Fix a bunch of [-Werror, -Winconsistent-missing-override] warnings.
Eric Christopher
echristo at gmail.com
Fri Dec 5 11:21:50 PST 2014
Author: echristo
Date: Fri Dec 5 13:21:49 2014
New Revision: 223501
URL: http://llvm.org/viewvc/llvm-project?rev=223501&view=rev
Log:
Fix a bunch of [-Werror,-Winconsistent-missing-override] warnings.
Modified:
lldb/trunk/source/Plugins/Platform/MacOSX/PlatformMacOSX.h
lldb/trunk/source/Plugins/Platform/MacOSX/PlatformRemoteiOS.h
lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.h
Modified: lldb/trunk/source/Plugins/Platform/MacOSX/PlatformMacOSX.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/MacOSX/PlatformMacOSX.h?rev=223501&r1=223500&r2=223501&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Platform/MacOSX/PlatformMacOSX.h (original)
+++ lldb/trunk/source/Plugins/Platform/MacOSX/PlatformMacOSX.h Fri Dec 5 13:21:49 2014
@@ -49,27 +49,27 @@ public:
//------------------------------------------------------------
// lldb_private::PluginInterface functions
//------------------------------------------------------------
- virtual lldb_private::ConstString
- GetPluginName()
+ lldb_private::ConstString
+ GetPluginName() override
{
return GetPluginNameStatic (IsHost());
}
- virtual uint32_t
- GetPluginVersion()
+ uint32_t
+ GetPluginVersion() override
{
return 1;
}
- virtual lldb_private::Error
+ lldb_private::Error
GetSharedModule (const lldb_private::ModuleSpec &module_spec,
lldb::ModuleSP &module_sp,
const lldb_private::FileSpecList *module_search_paths_ptr,
lldb::ModuleSP *old_module_sp_ptr,
- bool *did_create_ptr);
+ bool *did_create_ptr) override;
- virtual const char *
- GetDescription ()
+ const char *
+ GetDescription () override
{
return GetDescriptionStatic (IsHost());
}
@@ -79,24 +79,24 @@ public:
const lldb_private::UUID *uuid_ptr,
lldb_private::FileSpec &local_file);
- virtual lldb_private::Error
+ lldb_private::Error
GetFile (const lldb_private::FileSpec& source,
- const lldb_private::FileSpec& destination)
+ const lldb_private::FileSpec& destination) override
{
return PlatformDarwin::GetFile (source,destination);
}
- virtual lldb_private::Error
+ lldb_private::Error
GetFileWithUUID (const lldb_private::FileSpec &platform_file,
const lldb_private::UUID *uuid_ptr,
- lldb_private::FileSpec &local_file);
+ lldb_private::FileSpec &local_file) override;
virtual bool
GetSupportedArchitectureAtIndex (uint32_t idx,
- lldb_private::ArchSpec &arch);
+ lldb_private::ArchSpec &arch) override;
virtual lldb_private::ConstString
- GetSDKDirectory (lldb_private::Target &target);
+ GetSDKDirectory (lldb_private::Target &target) override;
void
AddClangModuleCompilationOptions (std::vector<std::string> &options) override
Modified: lldb/trunk/source/Plugins/Platform/MacOSX/PlatformRemoteiOS.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/MacOSX/PlatformRemoteiOS.h?rev=223501&r1=223500&r2=223501&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Platform/MacOSX/PlatformRemoteiOS.h (original)
+++ lldb/trunk/source/Plugins/Platform/MacOSX/PlatformRemoteiOS.h Fri Dec 5 13:21:49 2014
@@ -51,14 +51,14 @@ public:
//------------------------------------------------------------
// lldb_private::PluginInterface functions
//------------------------------------------------------------
- virtual lldb_private::ConstString
- GetPluginName()
+ lldb_private::ConstString
+ GetPluginName() override
{
return GetPluginNameStatic();
}
- virtual uint32_t
- GetPluginVersion()
+ uint32_t
+ GetPluginVersion() override
{
return 1;
}
@@ -66,35 +66,35 @@ public:
//------------------------------------------------------------
// lldb_private::Platform functions
//------------------------------------------------------------
- virtual lldb_private::Error
+ lldb_private::Error
ResolveExecutable (const lldb_private::ModuleSpec &module_spec,
lldb::ModuleSP &module_sp,
- const lldb_private::FileSpecList *module_search_paths_ptr);
+ const lldb_private::FileSpecList *module_search_paths_ptr) override;
- virtual const char *
- GetDescription ()
+ const char *
+ GetDescription () override
{
return GetDescriptionStatic();
}
- virtual void
- GetStatus (lldb_private::Stream &strm);
+ void
+ GetStatus (lldb_private::Stream &strm) override;
virtual lldb_private::Error
GetSymbolFile (const lldb_private::FileSpec &platform_file,
const lldb_private::UUID *uuid_ptr,
lldb_private::FileSpec &local_file);
- virtual lldb_private::Error
+ lldb_private::Error
GetSharedModule (const lldb_private::ModuleSpec &module_spec,
lldb::ModuleSP &module_sp,
const lldb_private::FileSpecList *module_search_paths_ptr,
lldb::ModuleSP *old_module_sp_ptr,
- bool *did_create_ptr);
+ bool *did_create_ptr) override;
- virtual bool
+ bool
GetSupportedArchitectureAtIndex (uint32_t idx,
- lldb_private::ArchSpec &arch);
+ lldb_private::ArchSpec &arch) override;
void
AddClangModuleCompilationOptions (std::vector<std::string> &options) override
Modified: lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.h?rev=223501&r1=223500&r2=223501&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.h (original)
+++ lldb/trunk/source/Plugins/Platform/MacOSX/PlatformiOSSimulator.h Fri Dec 5 13:21:49 2014
@@ -49,14 +49,14 @@ public:
//------------------------------------------------------------
// lldb_private::PluginInterface functions
//------------------------------------------------------------
- virtual lldb_private::ConstString
- GetPluginName()
+ lldb_private::ConstString
+ GetPluginName() override
{
return GetPluginNameStatic();
}
- virtual uint32_t
- GetPluginVersion()
+ uint32_t
+ GetPluginVersion() override
{
return 1;
}
@@ -64,39 +64,39 @@ public:
//------------------------------------------------------------
// lldb_private::Platform functions
//------------------------------------------------------------
- virtual lldb_private::Error
+ lldb_private::Error
ResolveExecutable (const lldb_private::ModuleSpec &module_spec,
lldb::ModuleSP &module_sp,
- const lldb_private::FileSpecList *module_search_paths_ptr);
+ const lldb_private::FileSpecList *module_search_paths_ptr) override;
- virtual const char *
- GetDescription ()
+ const char *
+ GetDescription () override
{
return GetDescriptionStatic();
}
- virtual void
- GetStatus (lldb_private::Stream &strm);
+ void
+ GetStatus (lldb_private::Stream &strm) override;
virtual lldb_private::Error
GetSymbolFile (const lldb_private::FileSpec &platform_file,
const lldb_private::UUID *uuid_ptr,
lldb_private::FileSpec &local_file);
- virtual lldb_private::Error
+ lldb_private::Error
GetSharedModule (const lldb_private::ModuleSpec &module_spec,
lldb::ModuleSP &module_sp,
const lldb_private::FileSpecList *module_search_paths_ptr,
lldb::ModuleSP *old_module_sp_ptr,
- bool *did_create_ptr);
+ bool *did_create_ptr) override;
- virtual uint32_t
+ uint32_t
FindProcesses (const lldb_private::ProcessInstanceInfoMatch &match_info,
- lldb_private::ProcessInstanceInfoList &process_infos);
+ lldb_private::ProcessInstanceInfoList &process_infos) override;
- virtual bool
+ bool
GetSupportedArchitectureAtIndex (uint32_t idx,
- lldb_private::ArchSpec &arch);
+ lldb_private::ArchSpec &arch) override;
void
AddClangModuleCompilationOptions (std::vector<std::string> &options) override
More information about the lldb-commits
mailing list