[Lldb-commits] [PATCH] 5 minute timeout for tests

[Chaoren Lin]

os.system didn't return the correct exit code (124). And I believe
subprocess.call is intended to replace os.system anyway according to this
<https://docs.python.org/2/library/subprocess.html#module-subprocess>.

On Wed Dec 03 2014 at 4:33:01 PM Zachary Turner <zturner at google.com> wrote:

> ================
> Comment at: test/dosep.py:42
> @@ +41,3 @@
> +        )
> +        exit_code = subprocess.call(command, shell=True)
> +        if 0 != exit_code:
> ----------------
> This appears to be equivalent to the previous code, but using subprocess
> instead of os.  If this is the only reason in the entire file for importing
> subprocess, then can we change it back to os.system to avoid importing the
> extra module?  Or alternatively, if the previous call to os.system was the
> only reason in the entire file for importing os, then keep the
> subprocess.call but remove the import of os.system.
>
> Other than that, LGTM
>
> http://reviews.llvm.org/D6364
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20141204/f723cae7/attachment.html>