[Lldb-commits] [PATCH] new lldb-mi token test and cleanup

[dawn at burble.org]

On Wed, Nov 26, 2014 at 12:08:10PM +0000, Abid, Hafiz wrote:
> Hi Dawn,
> This looks good to me. Just one question. You said that you removed the prompt check. So bad path test can be enabled. But the check for prompt is still there in the patch as show below and I has to remove this for test to work. I believe this was just an oversight but wanted to get confirmation before I commit this patch.
> 
> > -                child.expect_exact(prompt)
> > +                child.expect_exact(prompt) #FIXME: no prompt after error

Oops. Yes, it is supposed to be commented out:

> > -                child.expect_exact(prompt)
> > +                #child.expect_exact(prompt) #FIXME: no prompt after error

so we'll remember to add it back once the issue is fixed.
Not sure how that change got lost - thanks for catching it!

Thanks,
-Dawn