[Lldb-commits] [PATCH] os.remove shouldn't fail, if file doesn't exist
Ed Maste
emaste at freebsd.org
Fri Nov 21 17:04:34 PST 2014
Looks fine with a couple of minor comments.
================
Comment at: scripts/Python/buildSwigPython.py:431-433
@@ +430,5 @@
+"""
+Tries to remove given file. If file doesn't exist, the function will not throw.
+If an exception is thrown during remove, and errno is not ENOENT, then it will
+be rethrown. If errno is ENOENT, it will be ignored.
+"""
----------------
This comment seems overly verbose -- it's clear from reading the function that this is what happens. What about something succinct like "Remove a file, ignoring error if it does not exist."
================
Comment at: scripts/Python/buildSwigPython.py:604
@@ -589,2 +603,3 @@
+
#-----------------------------------------------------------------------------
----------------
random whitespace change
http://reviews.llvm.org/D6362
More information about the lldb-commits
mailing list