[Lldb-commits] [lldb] r222582 - Per off-list feedback, this API returns the *first* value with a given name, not the *only* one. Rename it to reflect that

Enrico Granata egranata at apple.com
Fri Nov 21 14:23:08 PST 2014


Author: enrico
Date: Fri Nov 21 16:23:08 2014
New Revision: 222582

URL: http://llvm.org/viewvc/llvm-project?rev=222582&view=rev
Log:
Per off-list feedback, this API returns the *first* value with a given name, not the *only* one. Rename it to reflect that

Modified:
    lldb/trunk/include/lldb/API/SBValueList.h
    lldb/trunk/scripts/Python/interface/SBValueList.i
    lldb/trunk/source/API/SBValueList.cpp

Modified: lldb/trunk/include/lldb/API/SBValueList.h
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/include/lldb/API/SBValueList.h?rev=222582&r1=222581&r2=222582&view=diff
==============================================================================
--- lldb/trunk/include/lldb/API/SBValueList.h (original)
+++ lldb/trunk/include/lldb/API/SBValueList.h Fri Nov 21 16:23:08 2014
@@ -45,7 +45,7 @@ public:
     GetValueAtIndex (uint32_t idx) const;
     
     lldb::SBValue
-    GetValueByName (const char* name) const;
+    GetFirstValueByName (const char* name) const;
 
     lldb::SBValue
     FindValueObjectByUID (lldb::user_id_t uid);

Modified: lldb/trunk/scripts/Python/interface/SBValueList.i
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/scripts/Python/interface/SBValueList.i?rev=222582&r1=222581&r2=222582&view=diff
==============================================================================
--- lldb/trunk/scripts/Python/interface/SBValueList.i (original)
+++ lldb/trunk/scripts/Python/interface/SBValueList.i Fri Nov 21 16:23:08 2014
@@ -98,7 +98,7 @@ public:
     FindValueObjectByUID (lldb::user_id_t uid);
     
     lldb::SBValue
-    GetValueByName (const char* name) const;
+    GetFirstValueByName (const char* name) const;
     
     %pythoncode %{
         def __len__(self):

Modified: lldb/trunk/source/API/SBValueList.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/API/SBValueList.cpp?rev=222582&r1=222581&r2=222582&view=diff
==============================================================================
--- lldb/trunk/source/API/SBValueList.cpp (original)
+++ lldb/trunk/source/API/SBValueList.cpp Fri Nov 21 16:23:08 2014
@@ -80,7 +80,7 @@ public:
     }
     
     lldb::SBValue
-    GetValueByName (const char* name) const
+    GetFirstValueByName (const char* name) const
     {
         if (name)
         {
@@ -277,11 +277,11 @@ SBValueList::FindValueObjectByUID (lldb:
 }
 
 SBValue
-SBValueList::GetValueByName (const char* name) const
+SBValueList::GetFirstValueByName (const char* name) const
 {
     SBValue sb_value;
     if (m_opaque_ap.get())
-        sb_value = m_opaque_ap->GetValueByName(name);
+        sb_value = m_opaque_ap->GetFirstValueByName(name);
     return sb_value;
 }
 





More information about the lldb-commits mailing list