[Lldb-commits] [PATCH] Implement a RegisterContext for Windows and hook it up to TargetThreadWindows

Greg Clayton clayborg at gmail.com
Thu Nov 20 12:31:35 PST 2014

We recently started using "override" in many places. I spoke with our C++ guys on the clang team and they agree that if you use the override key word that we should remove the virtual keyword, so we should fix this on new commits like this one.

Other than that it looks good. I don't understand the comment:

// For now we're only supporting general purpose registers.  Unfortunately we have to maintain
// parallel arrays since that's how the RegisterContext interface expects things to be returned.
// We might be able to fix this by initializing these arrays at runtime during the construction of
// the RegisterContext by using helper functions that can update multiple arrays, register sets,
// etc all at once through a more easily understandable interface.

Feel free to contact me offline for further comment.


More information about the lldb-commits mailing list