[Lldb-commits] [PATCH] Add test for denied process attach by pid and fix found bugs in Process/ProcessPOSIX.cpp

[Ed Maste]

overall lgtm

================
Comment at: source/Plugins/Process/FreeBSD/ProcessMonitor.cpp:1143
@@ -1143,3 +1142,3 @@
         args->m_error.SetErrorToErrno();
         goto FINISH;
     }
----------------
we probably ought to clean this up to just `return;` now - the goto is just extra obfuscation

================
Comment at: test/functionalities/process_attach/attach_denied/main.cpp:60
@@ +59,3 @@
+        fprintf (stderr, "fork failed: %s\n", strerror (errno));
+        return -1;
+    }
----------------
just `1` probably. -ve return values from main end up with implementation-specific results.

http://reviews.llvm.org/D6240