[Lldb-commits] [PATCH] Change the way SWIG is found, and fixed a typo in OS detection

Enrico Granata egranata at apple.com
Sun Nov 16 14:30:55 PST 2014


we don't really use CMake for building at apple, so this would be better directed towards the Linux folks.

As for the typo, I couldn't see anything but a bunch of semicolons removed
Is anything up with those, or am I missing the real change?

Sent from my iPhone

> On Nov 16, 2014, at 2:09 PM, Ismail Pazarbasi <ismail.pazarbasi at gmail.com> wrote:
> 
> Hi granata.enrico,
> 
> SWIG is searched under certain paths within python script. CMake can
> detect SWIG with `find_package(SWIG)`. This is used iff user checks
> `LLDB_ENABLE_PYTHON_SCRIPTS_SWIG_API_GENERATION`. If
> buildSwigWrapperClasses.py does not receive swigExecutable argument,
> then script will use its current search implementation.
> 
> This patch also fixes a typo in OS detection, where there is one too
> many equals in the assignment for Darwin.
> 
> http://reviews.llvm.org/D6290
> 
> Files:
>  scripts/CMakeLists.txt
>  scripts/buildSwigWrapperClasses.py
>  scripts/utilsArgsParse.py
>  scripts/utilsOsType.py
> <D6290.16278.patch>
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits




More information about the lldb-commits mailing list