[Lldb-commits] [PATCH] fix cmake build by linking LLVMSupport

Zachary Turner zturner at google.com
Fri Nov 14 19:35:02 PST 2014


================
Comment at: tools/lldb-platform/CMakeLists.txt:9-14
@@ -8,3 +8,8 @@
 
+llvm_config(lldb-platform support)
+if (LLVM_COMMON_DEPENDS)
+  add_dependencies(lldb-platform ${LLVM_COMMON_DEPENDS})
+endif()
+
 target_link_libraries(lldb-platform liblldb)
 
----------------
This looks better.  Should liblldb also be a dependency instead of just a link library?  In other words, I wonder if all this could be merged into the following:

add_dependencies(lldb-platform liblldb ${LLVM_COMMON_DEPENDS})

Otherwise it looks like no dependency is created between lldb-platform and liblldb.

http://reviews.llvm.org/D6270






More information about the lldb-commits mailing list