[Lldb-commits] [PATCH] suppress compiler warning (mostly -Wsign-compare)
jmolenda at apple.com
Fri Nov 14 14:14:42 PST 2014
One small comment but otherwise looks good to me, fwiw.
Comment at: tools/debugserver/source/RNBRemote.cpp:2219
@@ -2219,3 +2218,3 @@
- for (i = buf_size-1; i >= 0; i--)
+ for (long i = buf_size-1; i >= 0; i--)
ostrm << RAWHEX8(buf[i]);
I think 'i' should be size_t to match buf_size, right? That's how you changed the decl in the for loop below.
More information about the lldb-commits