[Lldb-commits] [PATCH] fix cmake build by linking LLVMSupport

Zachary Turner zturner at google.com
Fri Nov 14 13:24:41 PST 2014


================
Comment at: CMakeLists.txt:293-296
@@ -292,2 +292,6 @@
   add_llvm_executable(${name} ${ARGN})
+  llvm_config(${name} support)
+  if (LLVM_COMMON_DEPENDS)
+    add_dependencies(${name} ${LLVM_COMMON_DEPENDS})
+  endif()
   set_target_properties(${name} PROPERTIES FOLDER "lldb executables")
----------------
I don't think we should be hardcoding support here in the llvm_config call.  I'm also not sure why this is needed on lldb executables.  Is there an exe which is directly using LLVMSupport?  I thought we only used it from lldb libraries, which are then linked into the executables, and the libraries already correctly depend on LLVMSupport.

http://reviews.llvm.org/D6270






More information about the lldb-commits mailing list