[Lldb-commits] [lldb] r221760 - Enable armv7 core file writing for Mach-O binaries.

Jason Molenda jmolenda at apple.com
Tue Nov 11 18:39:15 PST 2014


Author: jmolenda
Date: Tue Nov 11 20:39:14 2014
New Revision: 221760

URL: http://llvm.org/viewvc/llvm-project?rev=221760&view=rev
Log:
Enable armv7 core file writing for Mach-O binaries.  
The problems with the dyld all image infos struct 
seems to be specific to arm64.

Modified:
    lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp

Modified: lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp?rev=221760&r1=221759&r2=221760&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp (original)
+++ lldb/trunk/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp Tue Nov 11 20:39:14 2014
@@ -5437,11 +5437,12 @@ ObjectFileMachO::SaveCore (const lldb::P
             bool make_core = false;
             switch (target_arch.GetMachine())
             {
-                  // arm and arm64 core file writing is having some problem with writing
-                  // down the dyld shared images info struct and/or the main executable binary.
-//                case llvm::Triple::arm:
+                  // arm64 core file writing is having some problem with writing  down the 
+                  // dyld shared images info struct and/or the main executable binary. May
+                  // turn out to be a debugserver problem, not sure yet.
 //                case llvm::Triple::aarch64:
 
+                case llvm::Triple::arm:
                 case llvm::Triple::x86:
                 case llvm::Triple::x86_64:
                     make_core = true;





More information about the lldb-commits mailing list