[Lldb-commits] [PATCH] Fix some warnings, one of which was a legit bug.
Zachary Turner
zturner at google.com
Mon Nov 10 11:23:37 PST 2014
Hi jasonmolenda,
MSVC warns that not all control paths return a value when a switch
doesn't have a default case handler. Changed explicit value checks
to a default check.
Also, it caught a case where bitwise AND was being used instead of
logical AND. I'm not sure what this fixes, but presumably it is
not covered by any kind of test case.
http://reviews.llvm.org/D6197
Files:
include/lldb/Interpreter/CommandInterpreter.h
source/Plugins/UnwindAssembly/x86/UnwindAssembly-x86.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6197.15999.patch
Type: text/x-patch
Size: 1563 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20141110/5b66673e/attachment.bin>
More information about the lldb-commits
mailing list