[Lldb-commits] [PATCH] Improve PowerPC unwind support

Ed Maste emaste at freebsd.org
Mon Nov 10 06:14:27 PST 2014


================
Comment at: source/Plugins/Process/FreeBSD/ProcessMonitor.cpp:320-323
@@ -316,2 +319,6 @@
             m_value = *(uintptr_t *)(((caddr_t)&regs) + m_offset);
-        else 
+        else if (m_size == sizeof(uint32_t))
+            m_value = *(uint32_t *)(((caddr_t)&regs) + m_offset);
+        else if (m_size == sizeof(uint64_t))
+            m_value = *(uint64_t *)(((caddr_t)&regs) + m_offset);
+        else
----------------
This will be dead code for one of the two cases (whichever has the same size as uintptr_t) no?

http://reviews.llvm.org/D6183






More information about the lldb-commits mailing list