[Lldb-commits] [PATCH] Improve PowerPC unwind support

Jason Molenda jason at molenda.com
Sun Nov 9 14:07:30 PST 2014

> On Nov 9, 2014, at 1:46 PM, Justin Hibbits <jrh29 at alumni.cwru.edu> wrote:
> On Nov 9, 2014 1:25 PM, "Jason Molenda" <jmolenda at apple.com> wrote:
> >
> > You should be calling SetCFARegisterNumberToDereference() here, shouldn't you?
> I completely missed that API when making the last patch and instead used the CFARegister and the type to determine how to get the CFA. One of these has to go, which do you think is the better API? I'll just remove the unnecessary one.

I'm fine with removing the SetCFARegisterNumberToDereference() and GetCFARegisterNumberToDereference() methods.  Callers will use GetCFAType() to decide whether the "CFARegister" is to be dereferenced or if the value in the reg is to be used as the CFA with the offset.

More information about the lldb-commits mailing list