[Lldb-commits] [PATCH] Improve PowerPC unwind support

[Justin Hibbits]

Unfortunately I can't. The unwind code depends on the 32-on-64 code in
order to give a valid back trace so becomes pointless without it. I guess I
could separate them and there would be no regression from the current
state, there just would be no gain.
On Nov 9, 2014 1:01 PM, "Ed Maste" <emaste at freebsd.org> wrote:

> I'd like to think about the 32-on-64 implementation some more. Can you
> submit the unwind changes separately first?
>
> ================
> Comment at: source/Plugins/ABI/SysV-ppc/ABISysV_ppc.cpp:1015
> @@ -1014,4 +1014,3 @@
>
> -    const int32_t ptr_size = 8;
> -    row->SetCFARegister (LLDB_REGNUM_GENERIC_SP);
> -    row->SetCFAOffset (8);
> +    const int32_t ptr_size = 4;
> +    row->SetCFARegister (sp_reg_num);
> ----------------
> I'd specifically call out this fix in the commit message
>
> http://reviews.llvm.org/D6183
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20141109/a1fc4e74/attachment.html>