[Lldb-commits] [PATCH] LLGS Android target support

Jim Ingham jingham at apple.com
Fri Nov 7 10:48:18 PST 2014

Most of this seems okay, but in a couple of places you either write stub versions of functions that are missing from the Android NDK.  std::to_string is done in the linux/Host.cpp, which seems like an appropriate place to put missing functions, but timegm and posix_openpt you do in the place where it is used (CXXFormatterFunctions.cpp and PseudoTerminal.cpp) which doesn’t seem right.  All these platform deficiencies should be gathered up in one place so that they can be shared among the source files.  Having them sprinkled throughout the sources will make the host dependencies harder to understand.

Also, I don’t know what your plans are for the EditLineAndroid, but if you are intending to just leave it as a stub, then call it EditLineStub or something like that, since there’s nothing Android specific about it.



More information about the lldb-commits mailing list