[Lldb-commits] [PATCH] Move NativeProcessProtocol and friends from Host/ to Target/

[Jim Ingham]

As I understood it originally, the NativeProcess stuff would end up replacing the guts of the ProcessLinux, etc, but in a way that would easily allow you to slot them into llgs as well.  That’s why I thought of them as some kind ur-process plugin.

Jim


> On Nov 4, 2014, at 2:31 PM, Zachary Turner <zturner at google.com> wrote:
> 
> Looking at this more closely, it seems to me like the process plugins contain two disjoint codepaths.  An llgs codepath (NativeProcessLinux, NativeProcessProtocol, etc) and a local debugging codepath (ProcessLinux, ProcessMonitor, etc).
> 
> This whole patch arose out of an effort to get local debugging working on Windows, because it looked like I needed to go through these NativeProcessProtocol and whatever.  But now it looks like this is not the case.  
> 
> It's not entirely clear why more of the code from ProcessLinux and the local debugging codepath wasn't re-used for the llgs side, but either way it looks like maybe I don't need to go down this route, and I can just have my debug driver thread communicate directly with ProcessWindows.
> 
> I'm happy to still commit this change (or make improvements as requested) if there's a better way to organize the code, but I'm also okay abandoning it since it seems it isn't necessary to get debugging working on this end.
> 
> http://reviews.llvm.org/D6123
> 
>