[Lldb-commits] [PATCH] Move NativeProcessProtocol and friends from Host/ to Target/

Zachary Turner zturner at google.com
Tue Nov 4 13:03:04 PST 2014


Hi jingham, clayborg,

I moved this for a number reasons:

1) There is no platform-specific code here so it does not seem to belong in Host
2) It is conceptually related to Target, and seems more appropriate there.
3) Code is using hackish include paths to #include from the source tree

Overall, it just seems like this code was in the wrong place.

http://reviews.llvm.org/D6123

Files:
  include/lldb/Target/NativeBreakpoint.h
  include/lldb/Target/NativeBreakpointList.h
  include/lldb/Target/NativeProcessProtocol.h
  include/lldb/Target/NativeThreadProtocol.h
  include/lldb/Target/Platform.h
  include/lldb/Target/SoftwareBreakpoint.h
  lldb.xcodeproj/project.pbxproj
  source/Host/CMakeLists.txt
  source/Host/common/NativeBreakpoint.cpp
  source/Host/common/NativeBreakpoint.h
  source/Host/common/NativeBreakpointList.cpp
  source/Host/common/NativeBreakpointList.h
  source/Host/common/NativeProcessProtocol.cpp
  source/Host/common/NativeProcessProtocol.h
  source/Host/common/NativeThreadProtocol.cpp
  source/Host/common/NativeThreadProtocol.h
  source/Host/common/SoftwareBreakpoint.cpp
  source/Host/common/SoftwareBreakpoint.h
  source/Plugins/Process/Linux/NativeProcessLinux.h
  source/Plugins/Process/Linux/NativeRegisterContextLinux_x86_64.cpp
  source/Plugins/Process/Linux/NativeThreadLinux.h
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.cpp
  source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServer.h
  source/Target/CMakeLists.txt
  source/Target/NativeBreakpoint.cpp
  source/Target/NativeBreakpointList.cpp
  source/Target/NativeProcessProtocol.cpp
  source/Target/NativeRegisterContext.cpp
  source/Target/NativeThreadProtocol.cpp
  source/Target/SoftwareBreakpoint.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D6123.15782.patch
Type: text/x-patch
Size: 151879 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20141104/e7f68070/attachment.bin>


More information about the lldb-commits mailing list