[Lldb-commits] [lldb] r220574 - Make ProcessWindows just use Host::LaunchProcess.

Zachary Turner zturner at google.com
Fri Oct 24 10:51:57 PDT 2014


Author: zturner
Date: Fri Oct 24 12:51:56 2014
New Revision: 220574

URL: http://llvm.org/viewvc/llvm-project?rev=220574&view=rev
Log:
Make ProcessWindows just use Host::LaunchProcess.

Modified:
    lldb/trunk/source/Host/windows/HostProcessWindows.cpp
    lldb/trunk/source/Plugins/Process/Windows/ProcessWindows.cpp

Modified: lldb/trunk/source/Host/windows/HostProcessWindows.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Host/windows/HostProcessWindows.cpp?rev=220574&r1=220573&r2=220574&view=diff
==============================================================================
--- lldb/trunk/source/Host/windows/HostProcessWindows.cpp (original)
+++ lldb/trunk/source/Host/windows/HostProcessWindows.cpp Fri Oct 24 12:51:56 2014
@@ -115,7 +115,7 @@ HostProcessWindows::MonitorThread(void *
         DWORD wait_result = ::WaitForSingleObject(info->process_handle, INFINITE);
         ::GetExitCodeProcess(info->process_handle, &exit_code);
         info->callback(info->baton, ::GetProcessId(info->process_handle), true, 0, exit_code);
-
+        ::CloseHandle(info->process_handle);
         delete (info);
     }
     return 0;

Modified: lldb/trunk/source/Plugins/Process/Windows/ProcessWindows.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Plugins/Process/Windows/ProcessWindows.cpp?rev=220574&r1=220573&r2=220574&view=diff
==============================================================================
--- lldb/trunk/source/Plugins/Process/Windows/ProcessWindows.cpp (original)
+++ lldb/trunk/source/Plugins/Process/Windows/ProcessWindows.cpp Fri Oct 24 12:51:56 2014
@@ -89,11 +89,7 @@ Error
 ProcessWindows::DoLaunch(Module *exe_module,
                          ProcessLaunchInfo &launch_info)
 {
-    Error error;
-    ProcessLauncherWindows launcher;
-    HostProcess process = launcher.LaunchProcess(launch_info, error);
-    launch_info.SetProcessID(process.GetProcessId());
-    return error;
+    return Host::LaunchProcess(launch_info);
 }
 
 Error





More information about the lldb-commits mailing list