[Lldb-commits] [PATCH] Fix swig interface for SBTarget.Launch

[Enrico Granata]

It seems that the problem was just the lack of a typecheck typemap that was causing SWIG to fail to understand that we know how to make a Python list of strings into a char const **
This should be fixed:
Sending        scripts/Python/python-typemaps.swig
Transmitting file data .
Committed revision 220306.

Before following up with this patch, can you please try this revision and see if it fixes things?
Make sure to delete your LLDBWrapPython.cpp before you rebuild - we have occasionally seen issues with the auto-regeneration process!

> On Oct 21, 2014, at 12:51 AM, Matthew Gardiner <mg11 at csr.com> wrote:
> 
> Two initial comments:
> 
> 1. applying the diff failed for me:
> 
> $ patch -p0 <D5878.diff 
> patching file scripts/Python/interface/SBTarget.i
> Hunk #1 succeeded at 279 with fuzz 2 (offset -146 lines).
> patching file test/api/multiple-debuggers/multi-process-driver.cpp
> patching file test/python_api/event/TestEvents.py
> Hunk #1 FAILED at 161.
> Hunk #2 FAILED at 229.
> 2 out of 2 hunks FAILED -- saving rejects to file test/python_api/event/TestEvents.py.rej
> patching file test/python_api/process/io/TestProcessIO.py
> patching file test/python_api/target/TestTargetAPI.py
> 
> Could you re generate this diff please? 
> 
> 2. Could you use a more descriptive name than Launch2 please?
> 
> http://reviews.llvm.org/D5878
> 
> 
> 
> _______________________________________________
> lldb-commits mailing list
> lldb-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/lldb-commits

Thanks,
- Enrico
📩 egranata@.com ☎️ 27683




-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/lldb-commits/attachments/20141021/8a3e861c/attachment.html>