[Lldb-commits] [lldb] r220220 - Don't allow the expression parser to magically

[Sean Callanan]

Author: spyffe
Date: Mon Oct 20 13:36:58 2014
New Revision: 220220

URL: http://llvm.org/viewvc/llvm-project?rev=220220&view=rev
Log:
Don't allow the expression parser to magically
look through 'self' at its ivars.  It produces
surprising results.

<rdar://problem/18698760>

Modified:
    lldb/trunk/source/Expression/ClangExpressionDeclMap.cpp
    lldb/trunk/source/Expression/ClangUserExpression.cpp

Modified: lldb/trunk/source/Expression/ClangExpressionDeclMap.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Expression/ClangExpressionDeclMap.cpp?rev=220220&r1=220219&r2=220220&view=diff
==============================================================================
--- lldb/trunk/source/Expression/ClangExpressionDeclMap.cpp (original)
+++ lldb/trunk/source/Expression/ClangExpressionDeclMap.cpp Mon Oct 20 13:36:58 2014
@@ -1275,7 +1275,6 @@ ClangExpressionDeclMap::FindExternalVisi
             valobj = frame->GetValueForVariableExpressionPath(name_unique_cstr,
                                                               eNoDynamicValues,
                                                               StackFrame::eExpressionPathOptionCheckPtrVsMember |
-                                                              StackFrame::eExpressionPathOptionsAllowDirectIVarAccess |
                                                               StackFrame::eExpressionPathOptionsNoFragileObjcIvar |
                                                               StackFrame::eExpressionPathOptionsNoSyntheticChildren |
                                                               StackFrame::eExpressionPathOptionsNoSyntheticArrayRange,

Modified: lldb/trunk/source/Expression/ClangUserExpression.cpp
URL: http://llvm.org/viewvc/llvm-project/lldb/trunk/source/Expression/ClangUserExpression.cpp?rev=220220&r1=220219&r2=220220&view=diff
==============================================================================
--- lldb/trunk/source/Expression/ClangUserExpression.cpp (original)
+++ lldb/trunk/source/Expression/ClangUserExpression.cpp Mon Oct 20 13:36:58 2014
@@ -620,7 +620,6 @@ GetObjectPointer (lldb::StackFrameSP fra
     valobj_sp = frame_sp->GetValueForVariableExpressionPath(object_name.AsCString(),
                                                             lldb::eNoDynamicValues,
                                                             StackFrame::eExpressionPathOptionCheckPtrVsMember |
-                                                            StackFrame::eExpressionPathOptionsAllowDirectIVarAccess |
                                                             StackFrame::eExpressionPathOptionsNoFragileObjcIvar |
                                                             StackFrame::eExpressionPathOptionsNoSyntheticChildren |
                                                             StackFrame::eExpressionPathOptionsNoSyntheticArrayRange,